Use the system font for header elements in popups #1515
Conversation
There was a problem hiding this comment.
What kind of content uses header elements and should we really apply those to all headers, even ones that come from a server? Or should we even just apply that font style to the whole popup? At this point, I'm not sure what doesn't use it since the p element does which is probably used in a lot of places.
<h1> is used a lot by clangd.
I would say yes, but I don't know how to do that in a neat way, because I suck at css. |
So we could just have a But we can just have |
|
Hmm... this also styles the diagnostics with the system font. I don't think that's an improvement. |
|
I managed to simplify it I think :) or can something go wrong with this? |
| } | ||
| .lsp_popup li { | ||
| font-family: system; | ||
| font-family: monospace; |
There was a problem hiding this comment.
I'm not sure how to "reset" the font-family here. The value monospace doesn't actually do what it is supposed to do: #1171 (comment)
There was a problem hiding this comment.
You are referring to a deleted line?
Not sure what do you exactly mean since the code doesn't look like that anymore.
There was a problem hiding this comment.
I wrote font-family: monospace; here, but that doesn't actually work as you'd expect. It just so happens to work. But the behavior is unconfirmed on Windows.
The only special font-family is presumably system.
No description provided.